chore: run CI tests on more node versions #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
But this will increase number of actions we may hit concurrent runs soon, which may cause some delay to merge things https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#about-billing-for-github-actions |
Contributor
Author
|
We can keep 2:
wdyt? |
Member
|
that would be perfect 👌 |
Contributor
Author
Which one? |
ChaituVR
reviewed
Oct 3, 2023
Co-authored-by: Chaitanya <yourchaitu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the github action tests on more node versions.
It's currently only ran on node 14, which is dead for many years.
Adding 16 (which is EOL but is still used by many of our services), 18 (current) and 20.
This will avoid scenario like #904 which fails on node 18