feat(overlord): add async script to set proposal scores value #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: fix types
fix: fix botched merge conflict chore: remove typo fix: fix typescript error fix: fix lint error fix: delete unused file
test: fix tests
it should be done async, via a separate infinite loop script
Co-authored-by: Less <bonustrack@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wa0x6e
force-pushed
the
feat-set-proposal-scores-value
branch
from
176da36 to
0d900d3
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+61
to
+71
| while (true) { | ||
| const proposals = await getProposals(); | ||
|
|
||
| if (proposals.length === 0) break; | ||
|
|
||
| if (proposals.length) { | ||
| await refreshVpByStrategy(proposals); | ||
| } | ||
|
|
||
| if (proposals.length < BATCH_SIZE) { | ||
| await snapshot.utils.sleep(REFRESH_INTERVAL); | ||
| if (proposals.length < BATCH_SIZE) break; | ||
| } | ||
|
|
||
| await snapshot.utils.sleep(REFRESH_INTERVAL); |
There was a problem hiding this comment.
Nested infinite loops create unreachable code. The outer while loop will never continue after the inner loop breaks, making it effectively dead code.
| expect.assertions(3); | ||
| mockGetSpace.mockResolvedValueOnce({ | ||
| ...spacesGetSpaceFixtures, | ||
| network: '56', // Using Ethereum mainnet, which is in the premium list |
There was a problem hiding this comment.
Comment incorrectly states network '56' is Ethereum mainnet, but '56' is actually BSC (Binance Smart Chain) network ID. Ethereum mainnet is network '1'.
Suggested change
| network: '56', // Using Ethereum mainnet, which is in the premium list | |
| network: '56', // Using BSC (Binance Smart Chain), which is in the premium list |
bonustrack
reviewed
Oct 1, 2025
src/helpers/proposalsScoresValue.ts
Outdated
| query.push('UPDATE proposals SET scores_total_value = ?, cb = ? WHERE id = ? LIMIT 1'); | ||
|
|
||
| try { | ||
| const scores_total_value = getProposalValue( |
Member
There was a problem hiding this comment.
We should never use snake case for root const name
Contributor
Author
|
Closing in favor of #595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation of #593
This PR will set the proposal's
scores_total_valuewith an async scriptIt's using a simple local computation, to get the total value, from existing data, only on closed proposals, and with final scores_state.