Netcode progress #300
Merged
Netcode progress #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bulk of work is matching NetManager functions that don't call DWC functions, as those aren't defined and are not in scope of this commit Additionally, various progress has been made, both on the source and header, of other net related classes
Report for RMCP01 (1d03278 - 929bf50)📈 Matched code: 5.69% (+0.04%, +2180 bytes) ✅ 15 new matches:
📈 1 improvements in unmatched functions:
📉 294 regressions in unmatched functions:
...and 264 more regressions in unmatched functions |
em-eight
reviewed
Jul 11, 2025
Contributor
em-eight
left a comment
em-eight
left a comment
There was a problem hiding this comment.
Very clean documentation, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk of work is matching NetManager functions, particularly the ones that don't call DWC functions that haven't been defined in the project as of this moment. Other than that, the various headers and functions of other net classes have been worked on. Looking for feedback on names
A few notes:
RACEHEADER1Handler::courseValid()andNetManager::getFriendJoinableStatus()have regswaps (Link and Link), and are also the two with the most awkward implementations. I don't know what the general policy is for merging functions with regswaps like thisMAX_FRIEND_COUNTandMAX_PLAYER_COUNTto live?