Skip to content

Conversation

@henrymkw
Copy link
Contributor

This PR fills the Net::NetManager header and starts progress on matching some of its functions. Any feedback is welcome.

@decomp-dev
Copy link

decomp-dev bot commented Jun 29, 2025

Report for RMCP01 (70d3016 - 6058f6d)

📈 Matched code: 5.65% (+0.05%, +2928 bytes)

✅ 27 new matches:
Unit Function Bytes Before After
StaticR/net/NetManager Net::NetManager::joinFriendRoom(unsigned long, unsigned char) +212 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::createFriendRoom(unsigned char) +192 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::startWWVSSearch(unsigned char) +188 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::startRegionalVSSearch(unsigned char) +188 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::startWWBattleSearch(unsigned char) +188 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::startRegionalBattleSearch(unsigned char) +188 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::isConnectionStateIdleOrInMM() +168 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::setDisconnectInfo(Net::DisconnectType, long) +148 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::isConnectionStateIdle() +144 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::DWCAlloc(unsigned long, unsigned long, long) +140 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::alloc(unsigned long, long) +136 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::SOAlloc(unsigned long, unsigned long) +128 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::getDisconnectInfo() +124 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::SOFree(unsigned long, void*) +104 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::DWCFree(unsigned long, void*) +104 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::free(void*) +100 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::getTimeDiff() +96 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::resetDisconnectInfo() +92 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::resetRH1andROOM() +88 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::hasFoundMatch() +64 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::isTaskExist() +44 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::setToMMSuspensionUnk2() +24 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::setToMMSuspensionUnk3() +24 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::scheduleShutdown() +12 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::setConnectionStateIdle() +12 0.00% 100.00%
StaticR/net/packets/RACEHEADER1 Net::RACEHEADER1Handler::setPrepared() +12 0.00% 100.00%
StaticR/net/NetManager Net::NetManager::setConnectionState(Net::NetManager::ConnectionState) +8 0.00% 100.00%
📉 613 regressions in unmatched functions:
Unit Function Bytes Before After
StaticR/auto_00_00142E54_text RKNetController_initStaticInstance 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_1457F8 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_14585C 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_145DF4 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_145E00 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_145EBC 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_145F78 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146034 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_1460F0 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146220 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146350 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146424 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_1464E4 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_14653C 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146554 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_14656C 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146600 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_14667C 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_1466D8 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146738 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146790 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_1467B8 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_1468EC 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_1469B8 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_1469E8 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146A90 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146ABC 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146B4C 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146B8C 0 0.00% 0.00%
StaticR/auto_00_00142E54_text fn_1_146C44 0 0.00% 0.00%

...and 583 more regressions in unmatched functions

@snailspeed3
Copy link
Owner

LGTM

@snailspeed3 snailspeed3 merged commit b4936a6 into snailspeed3:master Jun 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants