Update TokenBucket init to respect user TimeSource #4461
+184
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs tests, but want to see if it breaks any existing CI first
Motivation and Context
Closes #4459, WASM users were seeing runtime errors because some new functionality added to the
TokenBucketwas creating a defaultTimeSourcethat usedSystemTime. WASM is sandboxed and doesn't have access toSystemTime, so this caused a panic.Description
I updated the
TokenBucketcreation to initialize the bucket with the user-providedTimeSourcefrom theConfigAdded a task to #2499 to update our WASM integration tests to make sure we catch issues like this in the future.
Testing
Added integration test to ensure that the
TokenBucketfor an operation picks up theTimeSourcefrom theConfigif it is set.Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.