Add MCP proxy server support for prompts #1004
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adwsingh
requested changes
Dec 23, 2025
Comment on lines
+233
to
+235
| } catch (Exception e) { | ||
| LOG.error("Failed to fetch prompts from proxy: " + proxy.name(), e); | ||
| } |
Contributor
There was a problem hiding this comment.
We should not silently swallow. Don't do anything, if there is an exception let it bubble up.
Comment on lines
+256
to
+267
| for (McpServerProxy proxy : proxies.values()) { | ||
| try { | ||
| var response = proxy.rpc(req).join(); | ||
| if (response.getError() == null) { | ||
| return createSuccessResponse(req.getId(), response.getResult()); | ||
| } | ||
| } catch (Exception e) { | ||
| LOG.error("Failed to get prompt from proxy: " + proxy.name(), e); | ||
| } | ||
| } | ||
|
|
||
| throw new RuntimeException("Prompt not found: " + promptName); |
Contributor
There was a problem hiding this comment.
Why try again from the Proxy? This goes against the MCP spec too, if a prompt wasn't broadcasted as a part of list/prompts then it should not be returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.