feat: implement configurable mesh v2 parameters #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added environment variables for connection timeout, data update interval, event batch interval. - Added environment variable for host heartbeat interval. - Updated mesh-service.js to use these variables with default fallbacks. - Updated webpack.config.js to inject these variables.
- Added parseEnvInt helper for unified parsing and validation - Added descriptive comments and default values for Mesh v2 configuration - Updated .env.example with missing Mesh v2 parameters
- Renamed MESH_CONNECTION_TIMEOUT_MS to MESH_MAX_CONNECTION_TIME_SECONDS (unit: seconds) - Renamed MESH_HOST_HEARTBEAT_INTERVAL_MS to MESH_HOST_HEARTBEAT_INTERVAL_SECONDS (unit: seconds) - Added MESH_MEMBER_HEARTBEAT_INTERVAL_SECONDS (unit: seconds) - Updated implementation to handle seconds and convert to ms where needed - Updated .env.example and webpack.config.js
….env - Updated default intervals to match .env.example (1000ms for data/event, 60s/120s for heartbeats) - Added .env to .gitignore and untracked existing .env file
- Removed CONNECTION_TIMEOUT fallback in mesh-service.js - startConnectionTimer now relies solely on expiresAt from server - Removed variable from .env.example and webpack.config.js
- Added heartbeatIntervalSeconds to CREATE_GROUP mutation - Updated createGroup, renewHeartbeat, and joinGroup to capture interval from server - Updated startHeartbeat to use server interval instead of environment variables - Removed MESH_HOST_HEARTBEAT_INTERVAL_SECONDS and MESH_MEMBER_HEARTBEAT_INTERVAL_SECONDS
- Fixed unit tests failing due to immediate group expiration when expiresAt was in the past. - Added missing heartbeatIntervalSeconds to mock responses. Co-Authored-By: Gemini <noreply@google.com>
- Suppressed info/debug logs in Mesh V2 tests for better readability. - Kept info enabled in extension_mesh_v2_service.js for log verification. Co-Authored-By: Gemini <noreply@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements configurable Mesh v2 parameters to support cost reduction efforts outlined in issue #79.
Changes
MESH_CONNECTION_TIMEOUT_MSMESH_DATA_UPDATE_INTERVAL_MSMESH_EVENT_BATCH_INTERVAL_MSMESH_HOST_HEARTBEAT_INTERVAL_MSCost Reduction Strategy
These changes allow us to tune the following parameters in production without code changes:
Verification