fix: correct Mesh V2 cost calculation and message counting #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated connection multiplier from 3 to 1 to match unified subscription model - Moved message counter increments to subscription callback to include self-notifications - Updated unit tests to match new cost tracking architecture - Added mesh_service_v2_cost.js to verify accurate billing estimation Fixes #77 Related to smalruby/smalruby3-gui#500 🤖 Generated with [Gemini Code](https://gemini.google.com/code) Co-Authored-By: Gemini <noreply@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR corrects the cost estimation for Mesh V2 to accurately reflect AWS AppSync billing.
Changes
startSubscriptions) before filtering bynodeId. This ensures self-notifications are counted, as they are billed by AppSync even if ignored by the client.handleDataUpdateandhandleBatchEvent.mesh_service_v2_cost.js) to verify accurate billing estimation including self-notifications.Verification
npm run lint(Passed).npm run tap:unit(All 70 suites passed).Subscription Connection: 1000000.00 min × 1 = bash.08000000.Fixes #77
Related to smalruby/smalruby3-gui#500
🤖 Generated with Gemini Code
Co-Authored-By: Gemini noreply@google.com