Improved milestone selection dialog #741
Conversation
That would indeed make sense, I think.
What about placing a full-width 'Select none' or 'Any milestone' (wording improvements welcome) between the view pager and the button bar? That way we'd not mix selection and dialog dismissal in the button bar.
Worth a try, but my gut feeling is that the current version will look better. In general I think having more than one large block of color (let alone different colors) looks 'too much'. It's basically the same thing as with the advanced editor.
What do you mean by that? |
Go to issue edit screen and click on the button to add milestone. You can see here that the dialog has additional button which is missing in new design. |
Ah, right. Should be easy to add though when moving the deselect button out. |
Tunous
force-pushed
the
milestone-dialog
branch
from
1757a50 to
198bb05
Compare
|
Rebased onto latest master and finished missing changes. I'm still not convinced about the looks of this but at least now everything is functional. |
I've changed the milestone selection dialog to consist of view pager that allows for selection of closed milestones.
I'm not 100% sure about the look of this. We could modify a bit the appearance of milestones to highlight which one is selected. And I'm not really sure if the "deselect" button is a good idea. Sadly I don't have a better one. Also, we might want to colorize the pager tabs.
What is missing is the functionality of old "Manage milestones" buttons. We could add it like in old dialog (perhaps stack buttons) but I'm open to other suggestions.
Preview:
Closes #570