Skip to content

Conversation

@Tunous
Copy link
Collaborator

@Tunous Tunous commented Sep 11, 2017

This reproduces the behavior present on GitHub web interface where notifications and watched repositories are grouped under 2 tabs in the same page.

Related to #578 and #624

This reproduces the behavior present on GitHub web interface where notifications and watched repositories are grouped under 2 tabs in the same page.

Related to #578 and #624
Tunous added a commit that referenced this pull request Sep 16, 2017
@maniac103
Copy link
Collaborator

I don't use notifications myself, so I'm not sure whether this is a good idea, but just to have mentioned it: I wonder whether having the watched repo list optional instead of a tab, that is, have it accessible via toolbar button only.

@Tunous
Copy link
Collaborator Author

Tunous commented Sep 19, 2017

Personally, I would be happy with that option as I only use the notifications screen and rarely check my watched repositories. But, the aim of this change is to improve discoverability. Previously this entry was hidden in non-intuitive place. If we moved to overflow it would present a similar situation.

We could potentially move it to overflow menu for both Notifications and My Repositories screens but this seems more of a hack.

That's why I think tabs are the best option here. It's easy to find as it replicates tabbed interface in notifications screen on GitHub: https://github.com/watching

Tunous added a commit that referenced this pull request Sep 28, 2017
@maniac103
Copy link
Collaborator

I totally forgot to answer you :-/ I wasn't thinking of overflow, but a real toolbar menu item, like the filter one in the repo list. I don't think that would cause a discoverability problem.
What I'm not a fan of (and would like to avoid) is putting more or less unrelated content in two tabs. I don't really like having two tabs already (as it somehow feels like a waste of screen space), but especially not in this case, even if Github does it :-/

Tunous added a commit that referenced this pull request Mar 23, 2018
Tunous added a commit that referenced this pull request Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants