Skip to content

Comments

SK-2571 implement changes suggested in render zip design doc along with the unit test cases#673

Open
skyflow-bharti wants to merge 14 commits intorelease/26.2.6from
SK-2571-implement-changes-suggested-in-render-zip-design-doc-along-with-the-unit-test-cases
Open

SK-2571 implement changes suggested in render zip design doc along with the unit test cases#673
skyflow-bharti wants to merge 14 commits intorelease/26.2.6from
SK-2571-implement-changes-suggested-in-render-zip-design-doc-along-with-the-unit-test-cases

Conversation

@skyflow-bharti
Copy link
Collaborator

Why:
Address the feedback on zip render file from Design doc:

  1. update the styles names according to zip feature
  2. add listener for sending metadata of selected file
  3. Unit tests for the changes done in beta release

@github-actions
Copy link

🔐 Gitleaks Findings: 1 issue(s) detected

🔸 Rule: generic-api-key
📄 File: tests/core/internal/reveal/reveal-frame.test.js:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/internal/reveal/reveal-frame.test.js:null

@github-actions
Copy link

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@github-actions
Copy link

🔐 Gitleaks Findings: 1 issue(s) detected

🔸 Rule: generic-api-key
📄 File: tests/core/internal/reveal/reveal-frame.test.js:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/internal/reveal/reveal-frame.test.js:null

@github-actions
Copy link

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@skyflow-bharti skyflow-bharti changed the base branch from main to release/26.2.6 February 19, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants