MNT Improve typehints. #426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3803876.
Collaborator
Could you explain the reasoning? In general, for input arguments, it is preferred to use general types, so
Could you explain what parts? Failing CI seems to be unrelated. |
Contributor
|
looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started replacing
Sequencewithlist, and it ended up being a rabbit hole that I couldn't easily get out of.It also did raise some legit issues, so not all too bad, but there's a certain part that I can't figure out how to fix.
If you get a chance, I'd appreciate your wisdom @BenjaminBossan