Skip to content

Develop to beta - fix for the settings generation #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmytrotkk merged 3 commits into from
Feb 20, 2026
+3 −2
Merged

Develop to beta - fix for the settings generation #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b0066e
fix internal settings generation
dmytrotkk Feb 19, 2026
a4bcfb7
Merge branch 'develop' of github.com:skalenetwork/node-cli into fix-i…
dmytrotkk Feb 19, 2026
2929917
Merge pull request #959 from skalenetwork/fix-internal-settings-gener…
dmytrotkk Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion node_cli/core/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
print_node_cmd_error,
print_node_info,
)
from node_cli.utils.settings import validate_and_save_node_settings
from node_cli.utils.settings import save_internal_settings, validate_and_save_node_settings
from skale_core.settings import get_settings
from node_cli.utils.texts import safe_load_texts

Expand Down Expand Up @@ -154,6 +154,7 @@ def register_node(name, p2p_ip, public_ip, port, domain_name):
@check_not_inited
def init(config_file: str, node_type: NodeType) -> None:
node_mode = NodeMode.ACTIVE
save_internal_settings(node_type=node_type, node_mode=node_mode)
settings = validate_and_save_node_settings(config_file, node_type, node_mode)
compose_env = compose_node_env(node_type=node_type, node_mode=node_mode)

Expand Down Expand Up @@ -281,6 +282,7 @@ def update(
if (__version__ == 'test' or __version__.startswith('2.6')) and prev_version == '2.5.0':
migrate_2_6()
logger.info('Node update started')
save_internal_settings(node_type=node_type, node_mode=node_mode)
settings = validate_and_save_node_settings(config_file, node_type, node_mode)
compose_env = compose_node_env(node_type=node_type, node_mode=node_mode)
update_ok = update_op(settings=settings, compose_env=compose_env, node_mode=node_mode)
Expand Down
1 change: 0 additions & 1 deletion node_cli/operations/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ def init(settings: BaseNodeSettings, compose_env: dict, node_mode: NodeMode) ->
configure_nftables(enable_monitoring=settings.monitoring_containers)

prepare_host(env_type=settings.env_type)
save_internal_settings(node_type=NodeType.SKALE, node_mode=node_mode)

mark_active_node()

Expand Down
Loading