Merged
Conversation
…nternal-settings-generation
badrogger
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the node initialization and update workflows to ensure that internal settings are saved consistently when initializing or updating a node. The main change is to move the call to
save_internal_settingsfrom a lower-level operation to the higher-level CLI commands, ensuring settings are saved at the appropriate stage.Improvements to node initialization and update workflows:
save_internal_settingsfunction is now called at the start of both theinitandupdatefunctions innode_cli/core/node.py, ensuring internal settings are saved before further configuration steps. [1] [2]save_internal_settingsinnode_cli/operations/base.pyhas been removed, centralizing responsibility for saving internal settings in the CLI layer.Imports and dependencies:
save_internal_settingshas been added tonode_cli/core/node.pyto support the above changes.