Skip to content

Fix internal settings generation#959

Merged
dmytrotkk merged 2 commits intodevelopfrom
fix-internal-settings-generation
Feb 19, 2026
Merged

Fix internal settings generation#959
dmytrotkk merged 2 commits intodevelopfrom
fix-internal-settings-generation

Conversation

@dmytrotkk
Copy link
Collaborator

This pull request updates the node initialization and update workflows to ensure that internal settings are saved consistently when initializing or updating a node. The main change is to move the call to save_internal_settings from a lower-level operation to the higher-level CLI commands, ensuring settings are saved at the appropriate stage.

Improvements to node initialization and update workflows:

  • The save_internal_settings function is now called at the start of both the init and update functions in node_cli/core/node.py, ensuring internal settings are saved before further configuration steps. [1] [2]
  • The redundant call to save_internal_settings in node_cli/operations/base.py has been removed, centralizing responsibility for saving internal settings in the CLI layer.

Imports and dependencies:

  • The import of save_internal_settings has been added to node_cli/core/node.py to support the above changes.

@dmytrotkk dmytrotkk merged commit 2929917 into develop Feb 19, 2026
1 of 2 checks passed
@dmytrotkk dmytrotkk deleted the fix-internal-settings-generation branch February 19, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants