Skip to content

Conversation

@Emerichenon
Copy link

No description provided.

@AnkurGel
Copy link
Collaborator

AnkurGel commented Sep 4, 2016

@Emerichenon Few tests break. Also, probably it's not a good idea to raise Uber::Error::BadRequest for every failure code. Making some changes :) // cc @sishen

@sishen
Copy link
Owner

sishen commented Sep 4, 2016

@Emerichenon The error response will raise Farady::Error::ClientError. You can construct a friendly Uber::Error object in Client.rb#L138. Would you mind to update your PR there? Thank you.

@gabriel-dehan
Copy link

gabriel-dehan commented Sep 4, 2016

@AnkurGel Actual author here was working on a student's computer on a tight schedule while helping him with an uber relatied project. I'll make sure the tests passes or are you fixing it ?

@sishen Sure, we did not have much time so I didn't do the best fix in the world, I'll update it next week.

Cheers :)

@AnkurGel
Copy link
Collaborator

AnkurGel commented Sep 4, 2016

@sishen @gabriel-dehan Made some changes related to this here : #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants