Skip to content

Conversation

@darach
Copy link
Contributor

@darach darach commented Apr 23, 2025

Update the allocator text as snmalloc is in common use for simd-json with tremor and has been for years. Also, most of the goodness in mimalloc has since been merged into snmalloc. Rephrase accordingly.

Update the allocator text as snmalloc is in common use for simd-json with tremor and has been for years. Also, most of the goodness in mimalloc has since been merged into snmalloc. Rephrase accordingly.
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good catch, thanks!

@Licenser Licenser enabled auto-merge (rebase) April 23, 2025 09:23
@darach
Copy link
Contributor Author

darach commented Apr 23, 2025

I'm surprised we didn't catch this sooner. I mean, we've using snmalloc now for years! 🤷

@Licenser
Copy link
Member

yea I guess we don't often read our own readies 😅

@Licenser Licenser merged commit 0739a7a into main Apr 23, 2025
29 checks passed
@Licenser Licenser deleted the darach-readme-update-allocators-verbage branch April 23, 2025 09:28
@github-actions
Copy link

Benchmark for 0fae0f1

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 92.2±1.45µs 90.6±2.78µs -1.74%
canada/simd_json::to_tape_with_buffers 3.4±0.15ms 3.3±0.14ms -2.94%
citm_catalog/simd_json::to_tape_with_buffers 1069.4±73.72µs 1045.2±68.47µs -2.26%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.7±0.18µs 3.7±0.16µs 0.00%
github_events/simd_json::to_tape_with_buffers 40.7±0.91µs 40.2±0.79µs -1.23%
log/simd_json::to_tape_with_buffers 1569.3±85.50ns 1555.1±75.72ns -0.90%
twitter/simd_json::to_tape_with_buffers 430.0±27.48µs 421.3±25.36µs -2.02%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants