Skip to content

Conversation

@julien-lang
Copy link
Member

Problem

The banner info message displayed at the top of the Loader after triggering actions had poor contrast on macOS, especially in Photoshop and After Effects. The text appeared in beige color on a blue background, making it nearly unreadable.

Solution

Changed the banner text color from palette().text() to palette().highlightedText(). The highlightedText() color role is specifically designed for text displayed on highlight-colored backgrounds, ensuring proper contrast across all platforms.

Testing

  • Verify banner messages display with good contrast on macOS in Photoshop and After Effects
  • Confirm no visual regression on Windows or other DCCs

Fixes: SG-40910

The banner info message displayed at the top of the Loader after
triggering actions (e.g., "Open File") had poor contrast on macOS,
especially in Photoshop and After Effects. The text appeared in beige
color on a blue background, making it nearly unreadable.

The issue was caused by using palette().text() for the text color,
which is designed for use on the base background color, not on a
highlight background.

Changed to use palette().highlightedText() instead, which is
specifically designed for text displayed on highlight-colored
backgrounds, ensuring proper contrast across all platforms and
applications.

Fixes text readability in banner messages on macOS in Adobe DCCs.
@julien-lang julien-lang requested a review from Copilot January 30, 2026 23:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a contrast issue with banner text in the Loader on macOS, particularly in Adobe applications like Photoshop and After Effects, where text appeared in beige on blue making it difficult to read.

Changes:

  • Updated banner text color to use the appropriate palette role for highlighted backgrounds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@julien-lang julien-lang requested a review from a team January 30, 2026 23:49
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.72%. Comparing base (319e494) to head (d040144).
⚠️ Report is 28 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (319e494) and HEAD (d040144). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (319e494) HEAD (d040144)
16 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #132       +/-   ##
===========================================
- Coverage   77.09%   19.72%   -57.38%     
===========================================
  Files          33       35        +2     
  Lines        2633     2794      +161     
===========================================
- Hits         2030      551     -1479     
- Misses        603     2243     +1640     
Flag Coverage Δ
Linux 19.72% <ø> (?)
Python-3.10 19.72% <ø> (?)
Python-3.11 19.72% <ø> (?)
Python-3.9 19.72% <ø> (?)
Windows 19.72% <ø> (?)
macOS 19.72% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants