SG-41647 Deprecation warnigns for QTextCodec.setCodecForCStrings() #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1083 +/- ##
=======================================
Coverage 79.61% 79.62%
=======================================
Files 198 198
Lines 20623 20624 +1
=======================================
+ Hits 16420 16421 +1
Misses 4203 4203
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julien-lang
requested changes
Jan 29, 2026
python/tank/util/pyside6_patcher.py
Outdated
Comment on lines
102
to
103
| "QTextCodec.setCodecForCStrings() is obsolete and was removed in Qt6/PySide6 " | ||
| "and will be removed after September 2026. " |
Member
There was a problem hiding this comment.
Suggested change
| "QTextCodec.setCodecForCStrings() is obsolete and was removed in Qt6/PySide6 " | |
| "and will be removed after September 2026. " | |
| "QTextCodec.setCodecForCStrings() is obsolete and no longer exist since Qt5/PySide2. " | |
| "This method will be removed from Toolkit after December 2026. " |
python/tank/util/pyside2_patcher.py
Outdated
Comment on lines
79
to
80
| "QTextCodec.setCodecForCStrings() is obsolete and no longer exists in Qt5/PySide2 " | ||
| "and will be removed after September 2026. " |
Member
There was a problem hiding this comment.
Suggested change
| "QTextCodec.setCodecForCStrings() is obsolete and no longer exists in Qt5/PySide2 " | |
| "and will be removed after September 2026. " | |
| "QTextCodec.setCodecForCStrings() is obsolete and no longer exist since Qt5/PySide2. " | |
| "This method will be removed from Toolkit after December 2026. " |
julien-lang
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the PySide patcher utilities to issue deprecation warnings when the obsolete
QTextCodec.setCodecForCStrings()method is called, instead of silently ignoring the call. This helps developers identify and remove usage of this method before it is removed in the future.Deprecation warning improvements:
warnings.warncall in thesetCodecForCStringsstatic method inQTextCodecwithinpython/tank/util/pyside2_patcher.py, informing users that the method is obsolete, will be removed after September 2026, and should be removed from their code.warnings.warncall in thesetCodecForCStringsstatic method inQTextCodecwithinpython/tank/util/pyside6_patcher.py, with messaging tailored for Qt6/PySide6.General code update:
warningsmodule in bothpython/tank/util/pyside2_patcher.pyandpython/tank/util/pyside6_patcher.pyto support the new deprecation warnings. [1] [2]