feat: add NoEmptyResponseRule to detect empty HTTP response bodies#34
Open
Martin Bens (SpiGAndromeda) wants to merge 1 commit intomainfrom
Open
feat: add NoEmptyResponseRule to detect empty HTTP response bodies#34Martin Bens (SpiGAndromeda) wants to merge 1 commit intomainfrom
Martin Bens (SpiGAndromeda) wants to merge 1 commit intomainfrom
Conversation
Introduces NoEmptyResponseRule that detects Response class instantiations with empty or missing body content. The rule resolves body and status parameters by name from the constructor signature (e.g. content, data, body) and allows empty bodies for legitimate status codes (204, 301, 302, 303, 304, 307, 308).
| $responseType = new ObjectType(Response::class); | ||
| $classType = new ObjectType($className); | ||
|
|
||
| if (!$responseType->isSuperTypeOf($classType)->yes()) { |
Contributor
There was a problem hiding this comment.
what when I extend that class and create a own constructor with different args?
Collaborator
Author
There was a problem hiding this comment.
That should still work. Not with 100% precision though. Two constructor arguments are detected based on their names: the message and the status code. Validation is performed based on that. We can also easily extend the argument name lists.
But people would have to try to circumvent that, willingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.