Remove image proxy setup instructions from Docker guide#1929
Open
Shyim (shyim) wants to merge 2 commits intomainfrom
Open
Remove image proxy setup instructions from Docker guide#1929Shyim (shyim) wants to merge 2 commits intomainfrom
Shyim (shyim) wants to merge 2 commits intomainfrom
Conversation
Removed instructions for setting up an image proxy server in Docker.
Contributor
|
We should not remove the whole context here and just link to another page. I would add a small section explaining what "Image Proxy" means, especially since this also aims at beginners. Smth like : "An image proxy fetches production media files locally, avoiding CORS issues, reducing production load, and speeding up your local development environment." As a second note, the original content explained the Image proxy with settings without shopware-cli—this adds a layer of complexity. We don't have shopware-cli as a Prerequisite set on the article. The question is, do we want that in an easy setup? |
Contributor
|
Shyim (@shyim) what do you think about my feedback? |
Member
Author
|
sounds good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should stick to one solution for a problem :)