perf: make unix command loading non-blocking in completion hook#165
Open
jlguo wants to merge 1 commit intoshareAI-lab:mainfrom
Open
perf: make unix command loading non-blocking in completion hook#165jlguo wants to merge 1 commit intoshareAI-lab:mainfrom
jlguo wants to merge 1 commit intoshareAI-lab:mainfrom
Conversation
- Replace synchronous fs operations with async/await for better responsiveness - Use minimal fallback commands immediately to avoid UI blocking - Process PATH directories in batches with yields to event loop - Add error handling for individual file/directory access failures - Keep minimal fallback commands as fallback on load failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
readdirSync/statSyncwith asyncfs/promisesoperationsBenefits
Technical Details
setImmediateyieldingTest Plan
/or@) - should see immediate suggestionsCoworker: @claude
Issue: #164