Ng infinitescrol #12
Open
Ng infinitescrol #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Dont merge this one yet make sure you look at the commit.
Another suggestion... we will have to put some thought into this one because it will require people to have a dependency on ngInfinite scroll but you should def check this out. Basically we lazy load the first 200 and then once you scroll to the bottom we load more.
I tested this out in P2 and it did make a difference. There is some interceptor logic that breaks the template cache stuff you will have to deal with.
We basically add v=xyz for templates and u need to disable it for cached stuff.