Skip to content
This repository was archived by the owner on Oct 20, 2025. It is now read-only.

Conversation

@sgibb
Copy link
Owner

@sgibb sgibb commented Nov 8, 2021

Dear @paoloinglese,

thanks again for your great contribution in PR #71.
Unfortunately I can't modify your PR. That's why I closed #71 it and add this new one.

I did just a few minor changes (e.g. replacing the lapply(l, above.min) with tabulate).
If you are happy with this changes I will merge it into the main branch.

Best wishes,

Sebastian

BTW: will this make #70 obsolete for you?

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #72 (f817438) into master (b1ca2ff) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   88.44%   88.46%   +0.01%     
==========================================
  Files          81       82       +1     
  Lines        1411     1413       +2     
==========================================
+ Hits         1248     1250       +2     
  Misses        163      163              
Impacted Files Coverage Δ
R/AllGenerics.R 100.00% <100.00%> (ø)
R/as.list-functions.R 100.00% <100.00%> (ø)
R/as.matrix-functions.R 100.00% <100.00%> (ø)
R/filterPeaks-functions.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ca2ff...f817438. Read the comment docs.

@piplus2
Copy link
Contributor

piplus2 commented Nov 8, 2021

Dear Sebastian,

That sounds great!

BW,
Paolo

@sgibb sgibb merged commit 3d4f73f into master Nov 8, 2021
@sgibb sgibb deleted the occurrence-list branch November 8, 2021 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants