Add an optional field to the internal API to list target files #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backwards compatibility summary: |
bkettle
approved these changes
Jan 10, 2026
Contributor
bkettle
left a comment
bkettle
left a comment
There was a problem hiding this comment.
pr description pointing to the relevant pro PR or something would be nice
mjambon
force-pushed
the
martin/git-excludes
branch
from
da79307 to
1b84884
Compare
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Jan 13, 2026
…roprietary#5274) This is the first part of the work to speed-up SCA subproject discovery. It exposes an option to exclude patterns when listing untracked files with `git ls-files --others`. The included test serves as a mini example of how we can pass the patterns that match dependency sources (lockfiles and such). The second part of the work will consist primarily of deriving a list of patterns from the `MATCHERS` list and checking for speed and correctness. Uses semgrep/semgrep-interfaces#430 Test plan: CI checks synced from Pro 4f2923b14c80b35b3ff579ac34787f6c9b2f5e3f
ajbt200128
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Jan 13, 2026
…roprietary#5274) This is the first part of the work to speed-up SCA subproject discovery. It exposes an option to exclude patterns when listing untracked files with `git ls-files --others`. The included test serves as a mini example of how we can pass the patterns that match dependency sources (lockfiles and such). The second part of the work will consist primarily of deriving a list of patterns from the `MATCHERS` list and checking for speed and correctness. Uses semgrep/semgrep-interfaces#430 Test plan: CI checks synced from Pro 4f2923b14c80b35b3ff579ac34787f6c9b2f5e3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used by https://github.com/semgrep/semgrep-proprietary/pull/5274
make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!
semgrep-proprietaryare approved and ready to merge once this PR is merged