-
Notifications
You must be signed in to change notification settings - Fork 78
adjust to xarray datatree #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have added a decorator as now with any function mapping over datasets in the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 91.89% 91.85% -0.05%
==========================================
Files 45 45
Lines 6919 6885 -34
==========================================
- Hits 6358 6324 -34
Misses 561 561
|
closes #735
closes #740
Xarray has archived the
datatreerepository and includesDataTreenow directly inxarray. This comes with some changes, most notably thespatialdatarepo is affected by the fact thatDataTree.from_dictnow requires axr.Datasetinstead ofxr.DataArray, with the latter being marked as an inappropriate value. This PR fixes that.Note that the PR in spatial-image/multiscale-spatial-image#94 is still open for now so I did not add a new flag yet in
pyproject.toml. This would have to be done prior to merging this PR.Tests have been performed with the branch of
multiscale-spatial-imagein the mentioned PR and all pass locally.