[UEPR-488] Make Sprite selector items fully navigable via keyboard#442
Merged
adzhindzhi merged 14 commits intoscratchfoundation:release/UEPR-297-accessibility-improvementsfrom Feb 18, 2026
Conversation
d648afd to
5f120d1
Compare
There was a problem hiding this comment.
Pull request overview
Enables full keyboard navigation/activation for sprite selector items and related controls, improving accessibility semantics and focus management.
Changes:
- Replaced sprite item wrapper with a
<button>and added anaria-labelincluding sprite metadata. - Added key handling for Enter/Space on sprite items and delete buttons.
- Auto-focuses the “Yes/OK” button when the delete confirmation prompt opens.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.jsx | Converts sprite item to a button, adds aria-label and keyboard handling |
| packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.css | Removes default button styling to preserve existing visuals |
| packages/scratch-gui/src/components/delete-confirmation-prompt/delete-confirmation-prompt.jsx | Adds default focus to confirmation button on mount |
| packages/scratch-gui/src/components/delete-button/delete-button.jsx | Adds keyboard handling for Enter/Space on delete control |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.jsx
Show resolved
Hide resolved
packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/delete-button/delete-button.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.css
Outdated
Show resolved
Hide resolved
kbangelov
commented
Feb 12, 2026
packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.css
Outdated
Show resolved
Hide resolved
kbangelov
commented
Feb 12, 2026
packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.jsx
Outdated
Show resolved
Hide resolved
adzhindzhi
reviewed
Feb 13, 2026
packages/scratch-gui/src/components/delete-button/delete-button.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/delete-confirmation-prompt/delete-confirmation-prompt.jsx
Outdated
Show resolved
Hide resolved
adzhindzhi
reviewed
Feb 16, 2026
packages/scratch-gui/src/components/delete-confirmation-prompt/delete-confirmation-prompt.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.jsx
Show resolved
Hide resolved
packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.jsx
Outdated
Show resolved
Hide resolved
adzhindzhi
approved these changes
Feb 17, 2026
Contributor
adzhindzhi
left a comment
There was a problem hiding this comment.
Left two minor comments, but otherwise looks good to me! 🙌
packages/scratch-gui/src/components/delete-confirmation-prompt/delete-confirmation-prompt.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/delete-confirmation-prompt/delete-confirmation-prompt.jsx
Show resolved
Hide resolved
58dbbaa
into
scratchfoundation:release/UEPR-297-accessibility-improvements
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
https://scratchfoundation.atlassian.net/browse/UEPR-488
Proposed Changes
Reason for Changes
Part of accessibility initiative for Scratch.