[UEPR-483] "Choose a Sprite" and "Choose a Backdrop" keyboard accessibility#433
Open
kbangelov wants to merge 20 commits intoscratchfoundation:release/UEPR-297-accessibility-improvementsfrom
Conversation
e37597f to
f2902ce
Compare
adzhindzhi
reviewed
Feb 13, 2026
adzhindzhi
reviewed
Feb 16, 2026
packages/scratch-gui/src/components/action-menu/action-menu.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/action-menu/action-menu.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/action-menu/action-menu.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/action-menu/action-menu.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/action-menu/action-menu.jsx
Outdated
Show resolved
Hide resolved
adzhindzhi
reviewed
Feb 17, 2026
packages/scratch-gui/src/components/action-menu/action-menu.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/action-menu/action-menu.jsx
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/action-menu/action-menu.jsx
Outdated
Show resolved
Hide resolved
adzhindzhi
reviewed
Feb 18, 2026
There was a problem hiding this comment.
Pull request overview
Improves keyboard accessibility for the “Choose a Sprite” / “Choose a Backdrop” action menus in Scratch GUI as part of the accessibility initiative (UEPR-483).
Changes:
- Refactors
ActionMenufrom a class component to a hook-based functional component and adds keyboard navigation/focus handling. - Updates
ActionMenubutton styling to show focus state similar to hover. - Minor test/comment and formatting cleanup.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/scratch-gui/test/integration/sounds.test.js | Adds a clarifying comment for the keyboard shortcuts integration test. |
| packages/scratch-gui/src/components/stage-selector/stage-selector.jsx | Removes an extraneous blank line in the moreButtons config. |
| packages/scratch-gui/src/components/action-menu/action-menu.jsx | Implements keyboard navigation + refactors ActionMenu to hooks/memoization. |
| packages/scratch-gui/src/components/action-menu/action-menu.css | Adds :focus styling to match hover for action menu buttons. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/scratch-gui/src/components/action-menu/action-menu.jsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
https://scratchfoundation.atlassian.net/browse/UEPR-483
Proposed Changes
Reason for Changes
Part of accessibility initiative for Scratch.