Skip to content

[UEPR-483] "Choose a Sprite" and "Choose a Backdrop" keyboard accessibility#433

Open
kbangelov wants to merge 20 commits intoscratchfoundation:release/UEPR-297-accessibility-improvementsfrom
kbangelov:task/uepr-483-choose-a-sprite-and-backdrop-accessibility
Open

[UEPR-483] "Choose a Sprite" and "Choose a Backdrop" keyboard accessibility#433
kbangelov wants to merge 20 commits intoscratchfoundation:release/UEPR-297-accessibility-improvementsfrom
kbangelov:task/uepr-483-choose-a-sprite-and-backdrop-accessibility

Conversation

@kbangelov
Copy link
Contributor

@kbangelov kbangelov commented Feb 3, 2026

Resolves

https://scratchfoundation.atlassian.net/browse/UEPR-483

Proposed Changes

  • Adds keyboard navigation logic.
  • UI bug: tooltips don't refresh in case of first open or shift+tab-ing back to the menu.

Reason for Changes

Part of accessibility initiative for Scratch.

@kbangelov kbangelov requested a review from a team as a code owner February 3, 2026 14:18
@adzhindzhi adzhindzhi changed the base branch from develop to release/accessibility-improvements February 6, 2026 09:27
@kbangelov kbangelov force-pushed the release/accessibility-improvements branch 2 times, most recently from e37597f to f2902ce Compare February 13, 2026 09:00
@kbangelov kbangelov changed the base branch from release/accessibility-improvements to release/UEPR-297-accessibility-improvements February 13, 2026 10:10
@kbangelov kbangelov requested a review from adzhindzhi February 16, 2026 11:20
@kbangelov kbangelov requested a review from adzhindzhi February 17, 2026 11:00
@kbangelov kbangelov requested a review from adzhindzhi February 18, 2026 10:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves keyboard accessibility for the “Choose a Sprite” / “Choose a Backdrop” action menus in Scratch GUI as part of the accessibility initiative (UEPR-483).

Changes:

  • Refactors ActionMenu from a class component to a hook-based functional component and adds keyboard navigation/focus handling.
  • Updates ActionMenu button styling to show focus state similar to hover.
  • Minor test/comment and formatting cleanup.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
packages/scratch-gui/test/integration/sounds.test.js Adds a clarifying comment for the keyboard shortcuts integration test.
packages/scratch-gui/src/components/stage-selector/stage-selector.jsx Removes an extraneous blank line in the moreButtons config.
packages/scratch-gui/src/components/action-menu/action-menu.jsx Implements keyboard navigation + refactors ActionMenu to hooks/memoization.
packages/scratch-gui/src/components/action-menu/action-menu.css Adds :focus styling to match hover for action menu buttons.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@adzhindzhi adzhindzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments