Skip to content

fix mipmap resizing bug #6895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notimaginative merged 1 commit into from
Aug 2, 2025
Merged

fix mipmap resizing bug #6895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions code/graphics/opengl/gropengltexture.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,10 @@ static int opengl_texture_set_level(int bitmap_handle, int bitmap_type, int bmap
auto mipmap_w = tex_w;
auto mipmap_h = tex_h;

// should never have mipmap levels if we also have to manually resize
if ((mipmap_levels > 1) && resize) {
// if we are doing mipmap resizing we need to account for adjusted tex size
// (we can end up with only one mipmap level if base_level is high enough so don't check it)
if (base_level > 0) {
Assertion(resize == false, "Cannot use manual and mipmap resizing at the same time!");
Assert(texmem == nullptr);

// If we have mipmaps then tex_w/h are already adjusted for the base level but that will cause problems with
Expand Down
Loading