You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dit was een handmatige pick uit de wijzigingen die ik lokaal heb doorgevoerd. Mijn versie is 100% xhtml, maar dat heeft ook veel invloed op <header> die ik in deze PR niet wil aanpassen
http://tux.nl/Files/20181108095119.png ← do you want to check against my full repo?
FWIW - I run it on openSUSE 15.0 with Opera-developer on KDE/Plasma5
The point is that the title and alt strings are extracted from HTML source, and should already be properly encoded.
A small survey from the comics titles in my current config (99 out of 128 comics enabled) reveals that 13 comics have properly encoded entities in their titles, while only 2 have an unescaped &. (The rest is plain text.) BTW, the unescaped & is handled graciously by FireFox, don't know about Opera-developer.
So I think it is wrong to apply encode_entities to these strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dit was een handmatige pick uit de wijzigingen die ik lokaal heb doorgevoerd. Mijn versie is 100% xhtml, maar dat heeft ook veel invloed op <header> die ik in deze PR niet wil aanpassen