-
Notifications
You must be signed in to change notification settings - Fork 2
Updates to Dream instrument view #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@celinedurniak please take a look and see what you think. |
|
Hi, From your comments at #101 (comment)
|
|
@celinedurniak could you take another look at the new slider switching modes. |


We simplify and improve the performance of the Dream instrument view, and replace the single-valued slider with a range slider for the
tofdimension.Instead of having one node per detector bank that points to the scatter3d figure, we merge all banks from the data group into a single data array.
This vastly improves performance when moving clipping planes and interacting with the time-of-flight slider.
We had to remove the checkboxes that would hide/show individual banks, but it is believed that they were not very useful in practice (see #101 (comment)).
If we want to select a subset of banks, we filter from the data group that is sent to the view before creating it.
Users most likely will want to see all banks most of the time. Dynamically toggling is probably unnecessary.
Fixes #101
This would also fix #102 if scipp/plopp#479 is added to Plopp.