Skip to content

Conversation

@nvaytet
Copy link
Member

@nvaytet nvaytet commented Feb 3, 2026

We simplify and improve the performance of the Dream instrument view, and replace the single-valued slider with a range slider for the tof dimension.

Instead of having one node per detector bank that points to the scatter3d figure, we merge all banks from the data group into a single data array.
This vastly improves performance when moving clipping planes and interacting with the time-of-flight slider.

We had to remove the checkboxes that would hide/show individual banks, but it is believed that they were not very useful in practice (see #101 (comment)).
If we want to select a subset of banks, we filter from the data group that is sent to the view before creating it.
Users most likely will want to see all banks most of the time. Dynamically toggling is probably unnecessary.

Fixes #101

This would also fix #102 if scipp/plopp#479 is added to Plopp.

@nvaytet
Copy link
Member Author

nvaytet commented Feb 3, 2026

@celinedurniak please take a look and see what you think.

@celinedurniak
Copy link
Collaborator

Hi,
I tested the new instrument view using the notebook from the online documentation (https://scipp.github.io/essdiffraction/user-guide/dream/dream-instrument-view.html).

From your comments at #101 (comment)

  • I found the check boxes useful in order to display, for example, the mantle or the SANS or HR detector banks without having to deal with the endcaps.
    But as you mentioned, we can always code the display of a few selected banks instead of having check boxes.

  • For the slider, it would be nice to be able to select between a range slider and a standard one because if the range is too small, it is difficult to move.

@nvaytet nvaytet marked this pull request as ready for review February 4, 2026 22:51
@nvaytet
Copy link
Member Author

nvaytet commented Feb 4, 2026

For the slider, it would be nice to be able to select between a range slider and a standard one because if the range is too small, it is difficult to move.

I added some toggle buttons that allow to switch between range slider and single slice slider.
Screenshot_20260204_235249

@nvaytet
Copy link
Member Author

nvaytet commented Feb 9, 2026

@celinedurniak could you take another look at the new slider switching modes.
Also, try out the new value based cuts (you will need plopp==26.2.0)

@celinedurniak
Copy link
Collaborator

Thanks for the implementation. Everything works fine.
But the buttons to choose between standard and range sliders do not appear with their full size (See screenshot below).
It is therefore difficult to know what can be done.

Screenshot 2026-02-10 at 05 47 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customising range of colorscale of 3D view Customising ToF range of 3D instrument view

2 participants