feat: Asynchronous experiment cancellation#168
feat: Asynchronous experiment cancellation#168JoshHiles merged 3 commits intoscientistproject:masterfrom
Conversation
|
Tests were failing on a21eb17 as the Anyways the null ref ex throws earlier as we build the Behaviours from the Candidate which causes the null ref ex to throw earlier. I think this is correct way to fix but open to feedback |
M-Zuber
left a comment
There was a problem hiding this comment.
LGTM
there is that one variable that looks like it should have been removed
I've double checked the project build settings and we do have level 4 warnings & we don't have |
TBH I don't know |
|
Groovy! |
this closes #165
New
experiment.WithCancellationToken()& overloads for the asyncTry&Catch