Skip to content

Fix tag release action, add unit tests for PRs and CodeQL#164

Merged
JoshHiles merged 4 commits intoscientistproject:masterfrom
JoshHiles:master
Sep 27, 2025
Merged

Fix tag release action, add unit tests for PRs and CodeQL#164
JoshHiles merged 4 commits intoscientistproject:masterfrom
JoshHiles:master

Conversation

@JoshHiles
Copy link
Contributor

  • This should help build the release by switching to windows-latest which has the .NET frameworks preinstalled.

  • I've added unit test runs for PRs onto the main branch. This should run in parallel and test against the different frameworks.
    | The tests run on parallel with a windows & linux vm, would it be simpler to run on a PR just the linux then before a release do a whole multi framework test?

  • CodeQL also runs on PR to main branch & on any commit to main branch.
    | Not convinced running this EVERY PR & then again when its merged in but open to comments

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@JoshHiles JoshHiles assigned JoshHiles and M-Zuber and unassigned JoshHiles Sep 24, 2025
@JoshHiles
Copy link
Contributor Author

@dahlbyk Not sure if you could have a once over?

Copy link
Member

@dahlbyk dahlbyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As I've mentioned, feel free to give me Write permissions so my review counts. 😁

@dahlbyk
Copy link
Member

dahlbyk commented Sep 24, 2025

  • The tests run on parallel with a windows & linux vm, would it be simpler to run on a PR just the linux then before a release do a whole multi framework test?

I don't think we're in a particular hurry. I'm a fan of feedback before PRs land in main, all things being equal.

  • CodeQL also runs on PR to main branch & on any commit to main branch.
    | Not convinced running this EVERY PR & then again when its merged in but open to comments

Same.

@JoshHiles JoshHiles merged commit da5cf07 into scientistproject:master Sep 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants