Improvement/cldsrv 724 object related functional tests #5987

benzekrimaha · 2025-10-24T15:54:19Z

bert-e · 2025-10-24T15:54:23Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

codecov · 2025-10-24T15:56:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.35%. Comparing base (b74528b) to head (fc23278).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@                              Coverage Diff                               @@
##           improvement/CLDSRV-724-multiple-backend-tests    #5987   +/-   ##
==============================================================================
  Coverage                                          84.35%   84.35%           
==============================================================================
  Files                                                204      204           
  Lines                                              12928    12928           
==============================================================================
  Hits                                               10906    10906           
  Misses                                              2022     2022

Flag	Coverage Δ
kmip-ft-tests	`28.15% <ø> (ø)`
multiple-backend	`35.31% <ø> (ø)`
sur-tests	`36.43% <ø> (ø)`
sur-tests-inflights	`37.44% <ø> (-0.03%)`	⬇️
utapi-v2-tests	`34.32% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tests/functional/aws-node-sdk/test/object/bigMpu.js

ghost · 2025-10-28T08:10:40Z

tests/functional/aws-node-sdk/test/object/copyPart.js

+                        // with number of parts at the end)
                        assert.strictEqual(res.ETag,
                        '"5bba96810ff449d94aa8f5c5a859b0cb-2"');


The indent looks wrong in github diff view

tests/functional/aws-node-sdk/test/object/getPartSize.js

tests/functional/aws-node-sdk/test/object/mpu.js

ghost · 2025-10-28T08:15:47Z

tests/functional/aws-node-sdk/test/object/put.js

        it('should put an object and set the acl via query param',
-            done => {
+            async () => {
+                // Create a temporary file for upload


Suggested change

// Create a temporary file for upload

tests/functional/aws-node-sdk/test/object/100-continue.js

SylvainSenechal

Crazy pr 😅

DarkIsDude

Congrats again. Minor changes but we are good 👏

tests/functional/aws-node-sdk/test/object/bigMpu.js

DarkIsDude · 2025-12-05T16:55:10Z

tests/functional/aws-node-sdk/test/object/corsHeaders.js

+    const testS3 = new S3Client(config);
+    let capturedHeaders = {};
+
+    // Add middleware to capture response headers (similar to AWS SDK v2's event approach)


DarkIsDude · 2025-12-05T16:55:46Z

tests/functional/aws-node-sdk/test/object/corsHeaders.js

+            try {
+                const result = await next(args);
+
+                // Capture response headers (equivalent to request.on('success'))


I'm not sure it's really useful here. You have that in mind cause you did v2 to v3, but someone new will not understand

DarkIsDude · 2025-12-05T16:57:32Z

tests/functional/aws-node-sdk/test/object/deleteObject.js

+                    name: middlewareName,
+                };
+
+                // Add middleware


Suggested change

// Add middleware

tests/functional/aws-node-sdk/test/object/getPartSize.js

tests/functional/aws-node-sdk/test/object/mpu.js

Issue: CLDSRV-724

benzekrimaha changed the base branch from development/9.1 to improvement/CLDSRV-724-multiple-backend-tests October 24, 2025 15:54

scality deleted a comment from bert-e Oct 24, 2025

benzekrimaha force-pushed the improvement/CLDSRV-724-multiple-backend-tests branch 3 times, most recently from 327e859 to 58f8c81 Compare October 27, 2025 14:31

benzekrimaha force-pushed the improvement/CLDSRV-724-object-related-functional-tests branch 3 times, most recently from 69b2a4a to c56ac68 Compare October 27, 2025 16:32

benzekrimaha marked this pull request as ready for review October 27, 2025 16:33

benzekrimaha force-pushed the improvement/CLDSRV-724-multiple-backend-tests branch from 6d97621 to d8c1d88 Compare October 27, 2025 18:28

benzekrimaha force-pushed the improvement/CLDSRV-724-object-related-functional-tests branch from c56ac68 to 06547e0 Compare October 28, 2025 06:56

ghost approved these changes Oct 28, 2025

View reviewed changes

benzekrimaha force-pushed the improvement/CLDSRV-724-multiple-backend-tests branch 2 times, most recently from f0a4294 to c244695 Compare December 4, 2025 05:52

benzekrimaha force-pushed the improvement/CLDSRV-724-object-related-functional-tests branch from 06547e0 to 1166011 Compare December 4, 2025 06:10

benzekrimaha requested review from a team, DarkIsDude and francoisferrand December 4, 2025 14:40

SylvainSenechal reviewed Dec 5, 2025

View reviewed changes

tests/functional/aws-node-sdk/test/object/100-continue.js Show resolved Hide resolved

SylvainSenechal approved these changes Dec 5, 2025

View reviewed changes

DarkIsDude approved these changes Dec 5, 2025

View reviewed changes

benzekrimaha force-pushed the improvement/CLDSRV-724-multiple-backend-tests branch from da7043b to b74528b Compare December 23, 2025 15:37

benzekrimaha added 6 commits December 23, 2025 16:39

tests utilities migration

409dbc2

Issue: CLDSRV-724

mpu related tests migration

2550830

Issue: CLDSRV-724

cors related tests migration

2ce3606

Issue: CLDSRV-724

get operation related tests migration

e75adbd

Issue: CLDSRV-724

copy operation related tests migration

630b603

Issue: CLDSRV-724

put operation related tests migration

025bff0

Issue: CLDSRV-724

benzekrimaha added 6 commits December 23, 2025 16:39

delete operation related tests migration

9eb5777

Issue: CLDSRV-724

website related tests migration

919334c

Issue: CLDSRV-724

config migration

34cfeaf

Issue: CLDSRV-724

rest of object related tests migration

c8f535e

Issue: CLDSRV-724

additional dependencies install

6a5ae19

Issue: CLDSRV-724

fixups post reviews

fc23278

benzekrimaha force-pushed the improvement/CLDSRV-724-object-related-functional-tests branch from e3a5360 to fc23278 Compare December 23, 2025 15:40

Improvement/cldsrv 724 object related functional tests #5987

Are you sure you want to change the base?

Improvement/cldsrv 724 object related functional tests #5987

Conversation

benzekrimaha commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Oct 24, 2025

Hello benzekrimaha,

Uh oh!

codecov bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SylvainSenechal left a comment

Choose a reason for hiding this comment

Uh oh!

DarkIsDude left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DarkIsDude Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

DarkIsDude Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

DarkIsDude Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

benzekrimaha commented Oct 24, 2025 •

edited

Loading

codecov bot commented Oct 24, 2025 •

edited

Loading