Make STS destination port optional for CRR destinations

[francoisferrand]

We can use the transport (http or https) to compute a default port, so we don't need to patch the code in many places.

Issue: BB-733

[bert-e]

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.65%. Comparing base (1cd0f59) to head (340b38b).
⚠️ Report is 3 commits behind head on development/9.1.

Additional details and impacted files

Files with missing lines	Coverage Δ
...tensions/replication/ReplicationConfigValidator.js	100.00% <100.00%> (ø)
lib/constants.js	100.00% <ø> (ø)

... and 3 files with indirect coverage changes

Components	Coverage Δ
Bucket Notification	80.43% <ø> (ø)
Core Library	80.59% <ø> (-0.58%)	⬇️
Ingestion	70.31% <ø> (ø)
Lifecycle	78.70% <ø> (ø)
Oplog Populator	85.06% <ø> (ø)
Replication	61.24% <100.00%> (+0.02%)	⬆️
Bucket Scanner	85.76% <ø> (ø)

@@                 Coverage Diff                 @@
##           development/9.1    #2698      +/-   ##
===================================================
- Coverage            74.89%   74.65%   -0.24%     
===================================================
  Files                  200      200              
  Lines                13486    13488       +2     
===================================================
- Hits                 10100    10070      -30     
- Misses                3376     3408      +32     
  Partials                10       10              

Flag	Coverage Δ
api:retry	9.24% <50.00%> (+<0.01%)	⬆️
api:routes	9.05% <50.00%> (+<0.01%)	⬆️
bucket-scanner	85.76% <ø> (ø)
ft_test:queuepopulator	9.08% <50.00%> (-1.28%)	⬇️
ingestion	12.58% <50.00%> (+<0.01%)	⬆️
lib	7.80% <50.00%> (+<0.01%)	⬆️
lifecycle	18.97% <50.00%> (+<0.01%)	⬆️
notification	1.03% <0.00%> (-0.01%)	⬇️
replication	18.80% <50.00%> (+<0.01%)	⬆️
unit	50.90% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[delthas]

LGTM

[francoisferrand]

/approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/9.1

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.6
• development/9.0

Please check the status of the associated issue BB-733.

Goodbye francoisferrand.

The following options are set: approve