Fix generating policies/dashboards images on non-tag CI builds #2697

delthas · 2025-12-29T15:31:48Z

See: https://github.com/scality/Zenko/actions/runs/20490200343/job/58880923664#step:8:7327

an error stopped deployment: resource '\''management-vault-config'\'' reconciliation failed: subresource '\''management-vault-config'\'' build failed: build config.json config map entry: file extensions/lifecycle/conductor/policy_index_management.json not found in ghcr.io/scality/playground/delthas/backbeat/backbeat-policies/80f5d949fc5efad58a5d4a234f75c737876ef577:9.0.17

Issue: BB-734 Signed-off-by: Thomas Flament <thomas.flament@scality.com>

bert-e · 2025-12-29T15:31:51Z

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-12-29T15:32:00Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

Copilot

Pull request overview

This PR refactors the CI workflows to fix an issue with generating policies and dashboards images on non-tag builds by extracting duplicated ORAS push logic into a reusable composite GitHub Action.

Key changes:

Created a new composite action .github/actions/push-assets that consolidates ORAS installation and asset pushing logic
Removed duplicated code from both release.yaml and docker-build.yaml workflows
Standardized the asset push process across both production and development builds

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`.github/workflows/release.yaml`	Removed duplicated ORAS installation and asset push steps, replaced with call to new push-assets action using the release tag
`.github/workflows/docker-build.yaml`	Removed duplicated ORAS installation and asset push steps, replaced with call to new push-assets action using the git SHA
`.github/actions/push-assets/action.yml`	New composite action that encapsulates ORAS installation and pushing of dashboards and policies to container registry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/actions/push-assets/action.yml

codecov · 2025-12-29T15:46:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.65%. Comparing base (1cd0f59) to head (0d4f8c3).
⚠️ Report is 8 commits behind head on development/9.1.

Additional details and impacted files

see 3 files with indirect coverage changes

Components	Coverage Δ
Bucket Notification	`80.43% <ø> (ø)`
Core Library	`80.59% <ø> (-0.58%)`	⬇️
Ingestion	`70.31% <ø> (ø)`
Lifecycle	`78.70% <ø> (ø)`
Oplog Populator	`85.06% <ø> (ø)`
Replication	`61.21% <ø> (ø)`
Bucket Scanner	`85.76% <ø> (ø)`

@@                 Coverage Diff                 @@
##           development/9.1    #2697      +/-   ##
===================================================
- Coverage            74.89%   74.65%   -0.24%     
===================================================
  Files                  200      200              
  Lines                13486    13486              
===================================================
- Hits                 10100    10068      -32     
- Misses                3376     3408      +32     
  Partials                10       10

Flag	Coverage Δ
api:retry	`9.24% <ø> (ø)`
api:routes	`9.05% <ø> (ø)`
bucket-scanner	`85.76% <ø> (ø)`
ft_test:queuepopulator	`9.07% <ø> (-1.29%)`	⬇️
ingestion	`12.58% <ø> (ø)`
lib	`7.79% <ø> (ø)`
lifecycle	`18.97% <ø> (ø)`
notification	`1.03% <ø> (ø)`
replication	`18.79% <ø> (ø)`
unit	`50.89% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

.github/actions/push-assets/action.yml

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/release.yaml

.github/workflows/docker-build.yaml

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/release.yaml

delthas · 2025-12-31T14:37:03Z

/approve

bert-e · 2025-12-31T14:37:13Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: approve

SylvainSenechal · 2025-12-31T14:49:38Z

.github/workflows/docker-build.yaml

Side note : I believe we can do the exact same refactoring for the Cloudserver repository

Couldn't find a similar workflow code duplication in cloudserver. Could you point to the duplicate part?

bert-e · 2025-12-31T14:49:55Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/9.1

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.6
development/9.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2025-12-31T15:23:51Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.1

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.6
development/9.0

Please check the status of the associated issue BB-734.

Goodbye delthas.

Fix generating policies/dashboards images on non-tag CI builds

b40931e

Issue: BB-734 Signed-off-by: Thomas Flament <thomas.flament@scality.com>

delthas requested a review from Copilot December 29, 2025 15:31

Copilot started reviewing on behalf of delthas December 29, 2025 15:32 View session

Copilot AI reviewed Dec 29, 2025

View reviewed changes

.github/actions/push-assets/action.yml Outdated Show resolved Hide resolved

.github/actions/push-assets/action.yml Outdated Show resolved Hide resolved

delthas requested review from a team, SylvainSenechal and francoisferrand December 29, 2025 15:35

francoisferrand reviewed Dec 29, 2025

View reviewed changes

.github/actions/push-assets/action.yml Outdated Show resolved Hide resolved

fixup! Fix generating policies/dashboards images on non-tag CI builds

ec20bd4

delthas requested a review from Copilot December 30, 2025 13:59

Copilot started reviewing on behalf of delthas December 30, 2025 13:59 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

.github/workflows/release.yaml Outdated Show resolved Hide resolved

.github/workflows/docker-build.yaml Outdated Show resolved Hide resolved

fixup! Fix generating policies/dashboards images on non-tag CI builds

bcc6ef9

delthas requested a review from Copilot December 30, 2025 14:28

Copilot started reviewing on behalf of delthas December 30, 2025 14:29 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

delthas requested a review from francoisferrand December 30, 2025 15:15

francoisferrand reviewed Dec 30, 2025

View reviewed changes

.github/workflows/release.yaml Show resolved Hide resolved

fixup! Fix generating policies/dashboards images on non-tag CI builds

0d4f8c3

scality deleted a comment from bert-e Dec 31, 2025

francoisferrand approved these changes Dec 31, 2025

View reviewed changes

SylvainSenechal reviewed Dec 31, 2025

View reviewed changes

SylvainSenechal approved these changes Dec 31, 2025

View reviewed changes

bert-e merged commit 71c002c into development/9.1 Dec 31, 2025
10 checks passed

bert-e deleted the improvement/BB-734/fix-non-tag-policies branch December 31, 2025 15:23

Fix generating policies/dashboards images on non-tag CI builds #2697

Fix generating policies/dashboards images on non-tag CI builds #2697

Uh oh!

Conversation

delthas commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Dec 29, 2025

Hello delthas,

Uh oh!

bert-e commented Dec 29, 2025

Waiting for approval

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

delthas commented Dec 31, 2025

Uh oh!

bert-e commented Dec 31, 2025

Waiting for approval

Uh oh!

SylvainSenechal Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

delthas Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

bert-e commented Dec 31, 2025

In the queue

Uh oh!

bert-e commented Dec 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

delthas commented Dec 29, 2025 •

edited

Loading

codecov bot commented Dec 29, 2025 •

edited

Loading