Skip to content

Conversation

@delthas
Copy link
Contributor

@delthas delthas commented Dec 18, 2025

Used by Zenko, that uses environement variables rather than a configuration file currently.

Issue: BB-732

@bert-e
Copy link
Contributor

bert-e commented Dec 18, 2025

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 18, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for passing Kafka basic authentication credentials via environment variables (BASIC_USERNAME and BASIC_PASSWORD) as an alternative to using a credentials file. This enables Zenko to configure Kafka authentication using environment variables instead of configuration files.

Key Changes:

  • Updated validation schema to accept either credentialsFile or username/password for basic auth
  • Modified authentication logic to use direct credentials when credentialsFile is not provided
  • Added BASIC_USERNAME and BASIC_PASSWORD environment variables to task configuration

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
extensions/notification/NotificationConfigValidator.js Updated joi schema to make credentialsFile optional and added username/password fields with validation rules
extensions/notification/utils/auth.js Modified basic auth handling to support credentials from either file or direct username/password parameters
extensions/notification/queueProcessor/task.js Added BASIC_USERNAME and BASIC_PASSWORD environment variables to destinationAuth object
tests/unit/notification/NotificationConfigValidator.js Updated test descriptions and added test case for basic auth with username/password

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@delthas
Copy link
Contributor Author

delthas commented Dec 18, 2025

/status

@bert-e
Copy link
Contributor

bert-e commented Dec 18, 2025

Status

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 18, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@delthas delthas force-pushed the improvement/BB-732-basic-environment-variables branch from 84402bd to 6360420 Compare December 23, 2025 11:58
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.66%. Comparing base (1cd0f59) to head (ae6050b).

Files with missing lines Patch % Lines
extensions/notification/queueProcessor/task.js 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
...nsions/notification/NotificationConfigValidator.js 100.00% <ø> (ø)
extensions/notification/utils/auth.js 92.64% <100.00%> (+0.33%) ⬆️
extensions/notification/queueProcessor/task.js 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 80.40% <90.90%> (-0.03%) ⬇️
Core Library 80.61% <ø> (-0.56%) ⬇️
Ingestion 70.31% <ø> (ø)
Lifecycle 78.70% <ø> (ø)
Oplog Populator 85.06% <ø> (ø)
Replication 61.21% <ø> (ø)
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.1    #2693      +/-   ##
===================================================
- Coverage            74.89%   74.66%   -0.23%     
===================================================
  Files                  200      200              
  Lines                13486    13490       +4     
===================================================
- Hits                 10100    10072      -28     
- Misses                3376     3408      +32     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.24% <0.00%> (-0.01%) ⬇️
api:routes 9.05% <0.00%> (-0.01%) ⬇️
bucket-scanner 85.76% <ø> (ø)
ft_test:queuepopulator 9.07% <0.00%> (-1.29%) ⬇️
ingestion 12.57% <0.00%> (-0.01%) ⬇️
lib 7.79% <0.00%> (+<0.01%) ⬆️
lifecycle 18.96% <0.00%> (-0.01%) ⬇️
notification 1.03% <0.00%> (-0.01%) ⬇️
replication 18.79% <0.00%> (-0.01%) ⬇️
unit 50.90% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@delthas delthas force-pushed the improvement/BB-732-basic-environment-variables branch from 6360420 to 80f5d94 Compare December 23, 2025 12:54
Used by Zenko, that uses environement variables rather than a
configuration file currently.

Issue: BB-732
Signed-off-by: Thomas Flament <thomas.flament@scality.com>
@delthas delthas force-pushed the improvement/BB-732-basic-environment-variables branch from cdea8d6 to ae6050b Compare December 30, 2025 08:49
@delthas delthas requested review from a team, benzekrimaha and francoisferrand December 30, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants