Bump Java patch version#881
Open
razorheadfx wants to merge 1 commit intosbt:developfrom
razorheadfx:patch-1
Open
Bump Java patch version#881razorheadfx wants to merge 1 commit intosbt:developfrom razorheadfx:patch-1
razorheadfx wants to merge 1 commit intosbt:developfrom
razorheadfx:patch-1
Conversation
Changed ```11.0.4.hs-adpt``` to ```11.0.6.hs-adpt``` in install command as 11.0.4 is no longer available on SDKMAN. Currently this will require the docs to change every time AdoptOpenJDK retires/unlists a version. I just used SDKMAN for the first time so i assumed the guide was up to date (silly me :D) maybe explicitly forcing the user to list and select a version explicitely could easy for other first time users of both ```sbt``` and ```sdk```. For example ``` # use SDKMAN to list java versions sdk java list # select a AdoptOpenJDK 11 release version 11.y.z and then install it like so sdk install java 11.<y>.<z>.hs-adpt ```
|
Hi @razorheadfx, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
Member
|
@razorheadfx Thanks for the contribution. I think your suggestion about making it x y etc makes sense so we don't need to keep updating it. A more automated way of doing that is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
11.0.4.hs-adptto11.0.6.hs-adptin install command as 11.0.4 is no longer available on SDKMAN.Currently this will require the docs to change every time AdoptOpenJDK retires/unlists a version.
I just used SDKMAN for the first time so i assumed the guide was up to date (silly me :D) maybe explicitly forcing the user to list and select a version explicitely could prevent this fallacy for other first timers of both
sbtandsdk.For example