Fix #35 #124 to play channels 9..16 on second Arduino and allow more stepper track positions#178
Open
CC1337 wants to merge 3 commits intosamphonic:moppy-advancedfrom
Open
Fix #35 #124 to play channels 9..16 on second Arduino and allow more stepper track positions#178CC1337 wants to merge 3 commits intosamphonic:moppy-advancedfrom
CC1337 wants to merge 3 commits intosamphonic:moppy-advancedfrom
Conversation
…nd Arduino to play MIDI tracks 9..16 instead of 1..8
…se stepper motors from scanners etc with more than 255 possible steps
… notes but enables you to use the output to also turn on LEDs while playing
Owner
|
Hey there, so, my response here is unreasonably tardy-- sorry about that. I've been inspired recently to revamp Moppy to make it a bit better in a sort of general sense, but I'd also like to try to grab these improvements as well. It might be a few weeks, but I hope to get to this soon. Sorry about the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am using a second Arduino with steppers and did two changes for that. Unfortunately I now was unable to create separate pull requests :/
1st is to make the already mentioned second arduino configurable to play tracks 9-16 - easier to maintain when re-flashing them. Mainly took the code already suplied in #35 and #124 so thanks to the authors there.
2nd I changed the data type for the max stepper positions to int, if you do not use floppy drives but stepper motors connected to an A4988 stepper controller which has the same electrical interface it's possible to play longer notes > 255 steps :)
Thanks for this great work btw :)
CC