Fix recurring task sync: Preserve RRULE semantics and fix update bugs#5
Merged
Fix recurring task sync: Preserve RRULE semantics and fix update bugs#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug where recurring tasks synced as one-time tasks or lost recurrence rules during updates.
Changes
upsertTaskto always send recurrence payload on PATCH (update) requests, ensuring one-time tasks can be converted to recurring and rule changes propagate.deserializeRecurrenceto prevent broken series when DTSTART is missing.deserializeRecurrenceto handle WKST and TZID properly.Tests
test/extendedFields.test.tsto verify RRULE parsing/serialization round-trips.test/googleProvider.test.tsto verify persistence of machine-readable recurrence.test/microsoftProvider.test.tsto verify recurrence is sent on updates.