Skip to content

Add OffChainSignature support to eth_signTypedData_v4#657

Open
heri16 wants to merge 1 commit intosafe-global:mainfrom
heri16:patch-1
Open

Add OffChainSignature support to eth_signTypedData_v4#657
heri16 wants to merge 1 commit intosafe-global:mainfrom
heri16:patch-1

Conversation

@heri16
Copy link

@heri16 heri16 commented Dec 30, 2025

Add OffChainSignature support to eth_signTypedData_v4.


Note

Adds off-chain signature handling for typed data requests.

  • In provider.ts, when sdk.txs.signTypedMessage returns no signature but includes messageHash, fetch and return sdk.safe.getOffChainSignature(messageHash) instead of 0x for eth_signTypedData/eth_signTypedData_v4.

Written by Cursor Bugbot for commit cc09d1f. This will update automatically on new commits. Configure here.

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2025

⚠️ No Changeset found

Latest commit: cc09d1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant