Skip to content

Comments

Added drive stats and condensing & evaporating temps#115

Merged
sHedC merged 3 commits intosHedC:mainfrom
kysel:main
Jan 13, 2026
Merged

Added drive stats and condensing & evaporating temps#115
sHedC merged 3 commits intosHedC:mainfrom
kysel:main

Conversation

@kysel
Copy link
Contributor

@kysel kysel commented Jan 1, 2026

I've added drive stats - rps, drive voltage and current as displayed on pgd with calculated power to get better precision.
It is confirmed working on AQ30I. I don't have any other unit to test with.
image

I've also added condensing and evaporating temps, again tested on AQ30I.

@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (fd6e125) to head (8bcf838).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   90.31%   89.65%   -0.66%     
==========================================
  Files          10       10              
  Lines         764      764              
==========================================
- Hits          690      685       -5     
- Misses         74       79       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sHedC
Copy link
Owner

sHedC commented Jan 2, 2026

Thanks I will check this out @johny-mnemonic, can you have a look at this to see if the figures look good for you I will check the code and check against my system.

@sHedC sHedC self-assigned this Jan 2, 2026
@kysel
Copy link
Contributor Author

kysel commented Jan 2, 2026

Calculated power is not correct (due to 3-phase stuff), reverted back to pulling the power from VFD.
Also added comment on starts counter as pump stores it as /10 so to get number of starts you need to multiply that by 10.

@kysel kysel marked this pull request as ready for review January 2, 2026 17:37
@sHedC sHedC self-requested a review January 13, 2026 17:40
Copy link
Owner

@sHedC sHedC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and returning good values on my pump too, thanks

@sHedC sHedC merged commit 32598f6 into sHedC:main Jan 13, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants