Skip to content

Conversation

@golint-fixer
Copy link

I am a bot. Please reach out to @azillion if you have any issues, or just close the PR.

@rynbrd
Copy link
Owner

rynbrd commented Oct 24, 2018

Bot, this doesn't build!

@azillion
Copy link

Go versions less than 1.9 will fail because they are not supported by golang.org/x/lint/golint
Go Release Policy

@rynbrd
Copy link
Owner

rynbrd commented Oct 25, 2018

That's besides the point. If you're going to submit a PR it should at least build.

@azillion
Copy link

I disagree. Feel free to close the PR if you want

@rynbrd
Copy link
Owner

rynbrd commented Oct 25, 2018

My point is that you can't expect people to merge PR's that don't build. That's got nothing to do with the supported state of the linter or whatever the most recent Go version is.

In short: if it don't build it don't fly.

@azillion
Copy link

I have no expectations of people merging PR's they don't want. But even PR's with broken builds can still be helpful to people by making them aware that the version of Go they're using in a build is no longer supported by new releases. And for some that doesn't matter so they close the PR, and others update it. This was only meant to help, if it's not then please feel free to close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants