feat: reexpose osmpbfreader and ahash #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristramg
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some types from both
osmpbfreader(NodeIdandWayId) andahash(Edge::tags) are part ofosm4routingAPI. For consumers of the library, it creates a constraint of always needing to upgrade both dependencies together, making sure the versions are the same (or else, the compiler is not happy). One way some libraries deals with this is to reexpose the libraries, so then, the consumer can only depend onosm4routingonly (and don't need other dependencies). What do you think?We could also remove these lines
osm4routing2/src/osm4routing/models.rs
Line 5 in bc78837