impl WithTimeLimit for LpSolveProblem, CPLEXProblem, and lp-solvers Model<T>#116
Merged
lovasoa merged 2 commits intorust-or:mainfrom Nov 12, 2025
Merged
impl WithTimeLimit for LpSolveProblem, CPLEXProblem, and lp-solvers Model<T>#116lovasoa merged 2 commits intorust-or:mainfrom
lovasoa merged 2 commits intorust-or:mainfrom
Conversation
Contributor
Author
|
If this PR is admissible, could you also update the the good_lp crate version? I am part of a research group who is working on a FPGA technology mapping tool called EqMap, and we are working on integrating the good_lp crate into our project (https://github.com/cornell-zhang/eqmap/tree/good_lp). |
lovasoa
approved these changes
Nov 12, 2025
Collaborator
lovasoa
left a comment
lovasoa
left a comment
There was a problem hiding this comment.
Looks like the ci does not pass. Once you fix it, ok for me to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
These are possible implementations of the trait WithTimeLimit for structs LpSolveProblem, CPLEXProblem, and lp-solvers Model. The crate cplex-rs was updated to 0.1.9, since the new version contains the method env_mut() in impl Problem, which allows the WithTimeLimit implementation for CPLEXProblem to change the TimeLimit parameter of the Environment of the Problem. It would be greatly appreciated if you reviewed my code!