fix: remove lost eprintln

[willbush]

In how I'm using this crate not getting a solution to the constraints is a common thing and this eprintln is showing up in console output in context where no one would know where it came from. Seems like this can just be removed? Not sure if you want to add tracing or log crate dependency just for this.

[KnorpelSenf]

I'm pretty sure it was just forgotten, but let's wait for @lovasoa to confirm

[lovasoa]

thanks!

[KnorpelSenf]

I guess we first need to fix CI, but that is unrelated to these changes.

[KnorpelSenf]

@lovasoa do you have any idea why CI fails? It can be reproduced locally, but I honestly have no idea why the doctest fails. It works correctly for me if I do not compile the library to Wasm, and I am scared of diving into the wasm_bindgen rabbit hole just to fix this … if you can't figure it out either, I might do it anyway

[lovasoa]

I had a look, I don't know where it comes from but my opinion is that the incriminated test is stupid and can be removed altogether

[KnorpelSenf]

I love it. @willbush can you delete it yourself? We can merge right after.

[willbush]

I love it. @willbush can you delete it yourself? We can merge right after.

Sure. Looked into it a bit and I think it's failing because should_panic doc test expects a panic to be unwind (just guessing) panic strategy and the WASM target is probably abort or immediate-abort by default.

[willbush]

Actually, after looking at these docs, think we can just ignore targets that contain "wasm" and it will skip this test when running WASM test. Seems better than deleting the section on incompatible variables causing panic. Seems that's what other people are doing too https://github.com/search?q=%22%60%60%60should_panic%2Cignore-%22&type=code

[KnorpelSenf]

Those were the most plot twists I've ever seen on a pull request meant to delete a lost print statement

[lovasoa]

Thank you both !

[willbush]

Those were the most plot twists I've ever seen on a pull request meant to delete a lost print statement

I left out the best part. Someone smarter than me pointed out to me how I can formulate the problem so there's always a zero solution. So this "fix" doesn't really do anything for me afterall. 🎃🍫👻