-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[EXPERIMENT] GVN: Track known value ranges through assert and switchInt. #150192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
fad3972 to
ef766e1
Compare
This comment has been minimized.
This comment has been minimized.
ef766e1 to
bbf25db
Compare
This comment has been minimized.
This comment has been minimized.
bbf25db to
5734996
Compare
This comment has been minimized.
This comment has been minimized.
5734996 to
40d5520
Compare
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[EXPERIMENT] GVN: Track known value ranges through assert and switchInt.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (f2bc50f): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.1%, secondary 0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResults (primary -0.0%, secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 481.777s -> 483.166s (0.29%) |
|
☔ The latest upstream changes (presumably #150231) made this pull request unmergeable. Please resolve the merge conflicts. |
40d5520 to
5b217cf
Compare
5b217cf to
cbc2bb0
Compare
cbc2bb0 to
3837576
Compare
|
I don't think GVN is required here. A new pass with SSA locals may make sense. @cjgillot What do you think? |
r? ghost (for perf)