Skip to content

crash test readme: point to rustc-dev-guide #150109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tshepang wants to merge 2 commits into
base: main
Choose a base branch
from
Open

crash test readme: point to rustc-dev-guide #150109

tshepang wants to merge 2 commits into from
+6 −22

Conversation

@tshepang
Copy link
Member

@tshepang tshepang commented Dec 17, 2025

There is information that is duplicated here and in rustc-dev-guide, and the latter is more comprehensive, so point there.

@tshepang
crash test readme: point to rustc-dev-guide
977bf0a 
There is information that is duplicated here and in rustc-dev-guide, and the latter is more comprehensive, so point there.
@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2025

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

matthiaskrgr
matthiaskrgr requested changes Dec 17, 2025
View reviewed changes
tests/crashes/README.md Outdated
inside the testfile.

Please do not re-report any crashes that you find here!
Documentation on crash tests is at https://rustc-dev-guide.rust-lang.org/tests/compiletest#crash-tests
Copy link
Member

@matthiaskrgr matthiaskrgr Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a link is not going to be useful when there is no internet (for example when traveling on a train through rural areas)

Copy link
Member Author

@tshepang tshepang Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e17c2f3

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiaskrgr matthiaskrgr matthiaskrgr requested changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tshepang @rustbot @matthiaskrgr @Mark-Simulacrum