Look at proc-macro attributes when encountering unknown attribute #134841

estebank · 2024-12-28T03:17:51Z

error: cannot find attribute `sede` in this scope
  --> $DIR/missing-derive-2.rs:22:7
   |
LL |     #[sede(untagged)]
   |       ^^^^
   |
help: the derive macros `Deserialize` and `Serialize` accept the similarly named `serde` attribute
   |
LL |     #[serde(untagged)]
   |         +

error: cannot find attribute `serde` in this scope
  --> $DIR/missing-derive-2.rs:16:7
   |
LL |     #[serde(untagged)]
   |       ^^^^^
   |
note: `serde` is imported here, but it is a crate, not an attribute
  --> $DIR/missing-derive-2.rs:5:1
   |
LL | extern crate serde;
   | ^^^^^^^^^^^^^^^^^^^
help: `serde` is an attribute that can be used by the derive macros `Serialize` and `Deserialize`, you might be missing a `derive` attribute
   |
LL + #[derive(Serialize, Deserialize)]
LL | enum B {
   |

Partially address #47608. This PR doesn't find macros that haven't yet been imported by name.

rustbot · 2024-12-28T03:17:59Z

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_resolve/src/diagnostics.rs

wesleywiser · 2025-06-09T15:34:33Z

@bors r+ rollup

bors · 2025-06-09T15:34:35Z

📌 Commit b2f9a3f has been approved by wesleywiser

It is now in the queue for this repository.

estebank · 2025-06-09T19:31:26Z

@bors r=wesleywiser

bors · 2025-06-09T19:31:29Z

📌 Commit 3ed1787 has been approved by wesleywiser

It is now in the queue for this repository.

bors · 2025-06-11T20:52:54Z

⌛ Testing commit 69a3122 with merge b84566d...

bors · 2025-06-11T22:00:27Z

💔 Test failed - checks-actions

``` error: cannot find attribute `empty_helper` in this scope --> $DIR/derive-helper-legacy-limits.rs:17:3 | LL | #[empty_helper] | ^^^^^^^^^^^^ | help: `empty_helper` is an attribute that can be used by the derive macro `Empty`, you might be missing a `derive` attribute | LL + #[derive(Empty)] LL | struct S2; | ``` Look at proc-macro attributes when encountering unknown attribute ``` error: cannot find attribute `sede` in this scope --> src/main.rs:18:7 | 18 | #[sede(untagged)] | ^^^^ | help: the derive macros `Serialize` and `Deserialize` accept the similarly named `serde` attribute | 18 | #[serde(untagged)] | ~~~~~ error: cannot find attribute `serde` in this scope --> src/main.rs:12:7 | 12 | #[serde(untagged)] | ^^^^^ | = note: `serde` is in scope, but it is a crate, not an attribute help: `serde` is an attribute that can be used by the derive macros `Serialize` and `Deserialize`, you might be missing a `derive` attribute | 10 | #[derive(Serialize, Deserialize)] | ```

estebank · 2025-06-12T22:46:16Z

@bors r=wesleywiser

bors · 2025-06-12T22:46:19Z

📌 Commit 92a798d has been approved by wesleywiser

It is now in the queue for this repository.

bors · 2025-06-13T22:59:27Z

⌛ Testing commit 92a798d with merge d087f11...

bors · 2025-06-14T01:58:32Z

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing d087f11 to master...

github-actions · 2025-06-14T02:01:06Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8da6239 (parent) -> d087f11 (this PR)

Test differences

Show 14 test diffs

Stage 1

[ui] tests/ui/macros/missing-derive-1.rs: [missing] -> pass (J1)
[ui] tests/ui/macros/missing-derive-2.rs: [missing] -> pass (J1)
[ui] tests/ui/macros/missing-derive-3.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/macros/missing-derive-1.rs: [missing] -> pass (J0)
[ui] tests/ui/macros/missing-derive-2.rs: [missing] -> pass (J0)
[ui] tests/ui/macros/missing-derive-3.rs: [missing] -> pass (J0)

Additionally, 8 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d087f112b7d1323446c7b39a8b616aee7fa56b3d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 5617.4s -> 3428.9s (-39.0%)
x86_64-apple-1: 8936.4s -> 6185.4s (-30.8%)
dist-aarch64-apple: 4604.1s -> 5629.0s (22.3%)
dist-apple-various: 7919.5s -> 6243.7s (-21.2%)
aarch64-apple: 5190.8s -> 4330.2s (-16.6%)
dist-x86_64-apple: 9236.5s -> 7706.6s (-16.6%)
mingw-check-2: 2231.2s -> 1885.4s (-15.5%)
i686-gnu-1: 8471.4s -> 7221.1s (-14.8%)
mingw-check-1: 1961.5s -> 1677.9s (-14.5%)
i686-gnu-2: 6253.9s -> 5391.9s (-13.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-14T03:47:24Z

Finished benchmarking commit (d087f11): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.1%, 0.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.1%, secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	2.8%	[2.4%, 3.3%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-3.2%, -2.1%]	3
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Cycles

Results (secondary -6.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.7%	[-6.8%, -6.6%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 756.284s -> 757.156s (0.12%)
Artifact size: 372.34 MiB -> 372.29 MiB (-0.01%)

rustbot assigned wesleywiser Dec 28, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 28, 2024

This comment has been minimized.

Sign in to view

estebank force-pushed the serde-attr-4 branch from f88709b to 4a5ec26 Compare December 28, 2024 17:23

This comment was marked as resolved.

Sign in to view

estebank force-pushed the serde-attr-4 branch from 4a5ec26 to 291aaa9 Compare January 24, 2025 18:15

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

estebank force-pushed the serde-attr-4 branch from 21ea816 to b2f9a3f Compare March 9, 2025 20:17

This comment was marked as resolved.

Sign in to view

wesleywiser approved these changes Jun 6, 2025

View reviewed changes

compiler/rustc_resolve/src/diagnostics.rs Show resolved Hide resolved

wesleywiser approved these changes Jun 9, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2025

estebank force-pushed the serde-attr-4 branch from b2f9a3f to 3ed1787 Compare June 9, 2025 18:12

This was referenced Jun 10, 2025

Rollup of 13 pull requests #142278

Closed

Rollup of 12 pull requests #142283

Closed

fmease mentioned this pull request Jun 10, 2025

Rollup of 14 pull requests #142290

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 11, 2025

estebank force-pushed the serde-attr-4 branch from 69a3122 to 3c96a90 Compare June 12, 2025 21:00

estebank force-pushed the serde-attr-4 branch from 3c96a90 to 92a798d Compare June 12, 2025 21:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 14, 2025

bors merged commit d087f11 into rust-lang:master Jun 14, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 14, 2025

estebank mentioned this pull request Jun 14, 2025

Detect missing derive on unresolved attribute even when not imported #142487

Merged

Uh oh!

Look at proc-macro attributes when encountering unknown attribute #134841

Look at proc-macro attributes when encountering unknown attribute #134841

Uh oh!

Conversation

estebank commented Dec 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 28, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

wesleywiser commented Jun 9, 2025

Uh oh!

bors commented Jun 9, 2025

Uh oh!

estebank commented Jun 9, 2025

Uh oh!

bors commented Jun 9, 2025

Uh oh!

bors commented Jun 11, 2025

Uh oh!

This comment has been minimized.

bors commented Jun 11, 2025

Uh oh!

estebank commented Jun 12, 2025

Uh oh!

bors commented Jun 12, 2025

Uh oh!

bors commented Jun 13, 2025

Uh oh!

bors commented Jun 14, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 14, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 14, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

estebank commented Dec 28, 2024 •

edited

Loading