internal: Do not create stale expressions in body lowering #21209
+74
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
reviewed
Dec 8, 2025
| // FIXME: There should be no "unused variable" here, and there should be a mutability error, | ||
| // but our MIR infra is horribly broken and due to the order in which expressions are lowered | ||
| // there is no `StorageLive` for `x` in the closure (in fact, `x` should not even be a variable | ||
| // of the closure, the environment should be, but as I said, our MIR infra is horribly broken). |
ShoyuVanilla
approved these changes
Dec 8, 2025
rustbot
removed
the
S-waiting-on-review
Contributor
Author
|
Nice, this cut unknown types almost in half. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly because it created unknown types in analysis-stats and that pissed me. It took me a long time to realize the root cause.