Skip to content

Conversation

@JonathanWilbur
Copy link

Fixes #711

@JonathanWilbur
Copy link
Author

This currently isn't working. It seems that I have to make the ValueBag type support these new variants as well.

Example:

error[E0277]: the trait bound `ValueBag<'_>: From<std::net::SocketAddrV6>` is not satisfied
   --> src/kv/value.rs:388:39
    |
388 |                       Value::from_inner(value)
    |                       ----------------- ^^^^^ the trait `From<std::net::SocketAddrV6>` is not implemented for `ValueBag<'_>`
    |                       |
    |                       required by a bound introduced by this call
...

@KodrAus since you are the maintainer of the value-bag crate, would you take a PR to add variants for the core::net types, or is there a better way?

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. Where should we draw the line on what to support "natively" vs. using the fmt::Display implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement ToValue for IpAddr, and SocketAddr

2 participants